Add Cards package implementation #108
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements a new Cards package for the Microsoft Teams Python SDK, replacing a minimal AdaptiveCard placeholder with a full implementation. The changes update import statements and constructor calls throughout the codebase to align with the new Cards package structure.
- Replaces the minimal AdaptiveCard class with a full Cards package implementation
- Updates all AdaptiveCard constructor calls to use
model_validate()instead of direct instantiation - Consolidates import statements and updates project configuration
Reviewed Changes
Copilot reviewed 10 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/cards/src/microsoft/teams/cards/adaptive_card.py | Removes the minimal AdaptiveCard placeholder implementation |
| packages/app/src/microsoft/teams/app/app.py | Updates import to use new Cards package structure |
| packages/app/src/microsoft/teams/app/app_process.py | Updates import to use new Cards package structure |
| tests/message-extensions/src/cards.py | Updates AdaptiveCard instantiation to use model_validate() |
| tests/dialogs/src/main.py | Updates AdaptiveCard instantiation to use model_validate() |
| tests/graph/src/main.py | Consolidates imports from microsoft.teams.app |
| packages/graph/src/microsoft/teams/graph/auth_provider.py | Removes all export declaration |
| packages/graph/pyproject.toml | Updates build system from setuptools to hatchling |
| pyproject.toml | Updates pyright version and adds line length exception for cards package |
| pyrightconfig.json | Adds test paths and cards package configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
lilyydu
left a comment
lilyydu
left a comment
There was a problem hiding this comment.
could we match TS/C# and place the generator code into core.py instead? I'm gonna be adding the missing classes/folders that will use this file
https://github.com/microsoft/teams.ts/tree/main/packages/cards/src
Copy Pasted from https://1js-static-pages.azurewebsites.net/refs/heads/user/kumadeepak/4504356-ac-python-interface/ac-react-schema-tool/index.html?topic=ac-python-proxy.
Generated by the Adaptive Cards team.
Closes #57